Allow to configure guest_token cookie options #3621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
May 13, 2020
tvdeyen
force-pushed
the
allow-guest-token-cookie-domain
branch
from
80851e4
to
a1ae7c7
Compare
The guest_token cookie is currently always only allowed for the current domain (including subdomain). If you want to use the cookie on a static frontend communicating with your Solidus API you want to share the cookie with all subdomains (ie. www.example.com and api.example.com) in order for the cart session to still work. With this configuration you can do that.
tvdeyen
force-pushed
the
allow-guest-token-cookie-domain
branch
from
a1ae7c7
to
8caef37
Compare
aldesantis
approved these changes
May 13, 2020
|
Looking good @tvdeyen, thanks! I have re-run the tests because the failure seems random and not related. |
gmacdougall
approved these changes
May 13, 2020
kennyadsl
added
changelog:solidus_core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The guest_token cookie is currently always only allowed for the current domain (including subdomain).
If you want to use the cookie on a static frontend communicating with your Solidus API you want to share the cookie with all subdomains (ie. www.example.com and api.example.com) in order for the cart session to still work.
With this configuration you can do that.
Checklist: