Adding missing paginator when listing all stock locations #3600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
softr8
force-pushed
the
backend_admin_stock_location_pagination
branch
3 times, most recently
from
2efa3d9
to
1d45d02
Compare
jarednorman
reviewed
May 4, 2020
backend/app/controllers/spree/admin/stock_locations_controller.rb
Outdated
Show resolved
Hide resolved
|
@softr8 feel free to ping me for a review once the style violations addressed by @jarednorman have been fixed! |
softr8
force-pushed
the
backend_admin_stock_location_pagination
branch
from
1d45d02
to
3348622
Compare
Current implementation only list all stock locations limited by the defaulted per page value, but there's no way to navigate to multiple pages.
softr8
force-pushed
the
backend_admin_stock_location_pagination
branch
from
3348622
to
ca9a589
Compare
aldesantis
approved these changes
May 6, 2020
|
Thanks @softr8! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation only list all stock locations limited
by the defaulted per page value, but there's no way to navigate
to multiple pages.
Checklist: