[Backend] Handle errors and flash messages editing a taxon #3574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there was any error when trying to edit a taxon, it was not showing any error and just redirecting to taxons index, this change renders edit form showing errors correctly instead of just redirect without any flash message.
softr8
force-pushed
the
improve/taxon-edit
branch
from
acdadf8
to
5975bf0
Compare
| @@ -189,7 +189,7 @@ module Spree | |||
| end | |||
|
|
|||
| it "cannot create a new taxon with invalid attributes" do | |||
| post spree.api_taxonomy_taxons_path(taxonomy), params: { taxon: { foo: :bar } } | |||
| post spree.api_taxonomy_taxons_path(taxonomy), params: { taxon: { name: '' } } | |||
There was a problem hiding this comment.
I'm not sure about the reason why for this change, can you explain to me? thanks 🙏
There was a problem hiding this comment.
It was passing due the wrong check, it was actually passing because foo is not a permitted param, and using name it actually runs the validations
kennyadsl
approved these changes
Apr 17, 2020
kennyadsl
changed the title
kennyadsl
added
changelog:solidus_backend
aldesantis
approved these changes
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If there was any error when trying to edit a taxon, it
was not showing any error and just redirecting to taxons index,
this change renders edit form showing errors correctly instead
of just redirect without any flash message.
Checklist: