Update images sizes to the new defaults #3493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennyadsl
approved these changes
Jan 29, 2020
spaghetticode
approved these changes
Jan 31, 2020
There was a problem hiding this comment.
@elia thank you 👍 I left a non-blocking note, hope it makes sense!
| large=>"600x600>" | ||
| } | ||
| >> Spree::Image.attachment_definitions[:attachment][:styles] | ||
| => {:mini=>"48x48>", :small=>"400x400>", :product=>"680x680>", :large=>"1200x1200>"} | ||
| ``` | ||
|
|
||
| The default sizes can be changed in an initializer. For example, in your | ||
| `config/initializers/paperclip.rb` file. You can set new defaults like this: |
There was a problem hiding this comment.
Would it make sense to make it super clear that those were the old defaults? For example by changing the wording to something like:
You can set new defaults like this (these were the default values for Solidus up to version 2.9.x):
There was a problem hiding this comment.
@spaghetticode that's a great suggestion, it makes total sense for me. @elia thoughts?
Let the customization example use the old pre 2.10 defaults to make it easier to copy/paste the code for people landing on this page from the 2.10 changelog.
|
@kennyadsl @spaghetticode thanks for the comment! |
tvdeyen
approved these changes
Feb 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Let the customization example use the old pre 2.10 defaults to make it
easier to copy/paste the code for people landing on this page from the
2.10 changelog.
Checklist: