Pass stock location to inventory unit factory #3375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebased from master. |
When creating fulfilled stock packages in specs, this passes the given transient stock location to the inventory units that get built. This prevents the inventory unit factory from building unique stock locations for each inventory unit that gets built, and ensures that the stock package is using the same stock location as the inventory units it contains.
|
The build is now passing. What else needs to happen before this PR can be merged? |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When building fulfilled stock packages in specs using the stock package factory, this passes the given transient stock location to the inventory units that get built. This prevents the inventory unit factory from building unique stock locations for each inventory unit that gets built, and ensures that the stock package is using the same stock location as the inventory units it contains.
Checklist: