Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guides (API): Some additional API token info #3368

Merged
merged 1 commit into from
Jan 28, 2020

Conversation

felixyz
Copy link
Contributor

@felixyz felixyz commented Oct 7, 2019

UPDATE: Ignore everything below. All that remains is a small extra tip on where to find your API token and a curl example.

Description

The API guide states that the API token should be passed in through the Authentication header. I discovered this doesn't work, and from this line it looks like the correct header is X-Spree-Token, which also works in practice for me.

Either I misunderstood something, or the guides are wrong.

I also added a curl example and spelled out where people can find their admin token.

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)

@kennyadsl
Copy link
Member

kennyadsl commented Oct 7, 2019

@felixyz thanks for the contribution. Which Solidus version are you using? Recently, we deprecated X-Spree-Token, so I think guides are right. If the new header is not working for you, it's probably because you are on an old Solidus version, isn't it?

@felixyz
Copy link
Contributor Author

felixyz commented Oct 8, 2019

@kennyadsl 🤦‍♂️ haha you caught me there, now you can infer just how far behind I am with my updates.

How about the other stuff? It's tiny but perhaps worth merging?

@kennyadsl
Copy link
Member

Sure, I like the rest of the PR. This also needs a rebase to fix pending CI checks I guess. Thanks Felix!

@kennyadsl
Copy link
Member

@felixyz do you have time to complete this PR or it's better to close it?

@felixyz felixyz changed the title Guides (API): Authorization => X-Spree-Token Guides (API): Some additional API token info Nov 29, 2019
@felixyz
Copy link
Contributor Author

felixyz commented Nov 29, 2019

@kennyadsl Should be ready now.

Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Felix!

@aldesantis
Copy link
Member

Looking good, thanks!

@kennyadsl kennyadsl merged commit c9a2b9e into solidusio:master Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants