Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hook attr name for settings tab item in admin #3301

Merged
merged 1 commit into from
Aug 13, 2019
Merged

Fix hook attr name for settings tab item in admin #3301

merged 1 commit into from
Aug 13, 2019

Conversation

cedum
Copy link
Contributor

@cedum cedum commented Aug 12, 2019

This changes the hook attribute name for settings tab items (in admin) from:
datahook to data-hook.

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)

@cedum
Fix hook attr name for settings tab item in admin
2eacb5a 
This changes the hook attribute name for settings tab items from:
`datahook` to `data-hook`.
kennyadsl
kennyadsl approved these changes Aug 12, 2019
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks @cedum!

jacobherrington
jacobherrington approved these changes Aug 12, 2019
View reviewed changes
Copy link
Contributor

@jacobherrington jacobherrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@kennyadsl kennyadsl merged commit 764566c into solidusio:master Aug 13, 2019
@elia elia deleted the cedum/fix-admin-settings-tab-hook-attr branch February 4, 2020 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennyadsl kennyadsl kennyadsl approved these changes

@jacobherrington jacobherrington jacobherrington approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cedum @kennyadsl @jacobherrington