Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename one letter variables #3292

Merged

Conversation

jacobherrington
Copy link
Contributor

Description

This is a small tweak, personally, I find single-character variable names like these to be less than ideal. IMO no reason to not change these. 🤠

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)

Copy link
Member

@spaghetticode spaghetticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jacobherrington I completely agree, thank you 👍

@jacobherrington
Copy link
Contributor Author

@spaghetticode There are a bunch of these throughout the codebase. I might go in and do a more sweeping change in the future, but it would also make a good first-time contribution for anyone new to open source 😉

@spaghetticode
Copy link
Member

@jacobherrington I think that's a great idea! I will open an issue and mark it as beginner-friendly

Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just left a thought, non-blocking.

backend/app/helpers/spree/admin/navigation_helper.rb Outdated Show resolved Hide resolved
@jacobherrington jacobherrington merged commit d702e64 into solidusio:master Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants