Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cancel inventory tab for consistency #3289

Merged
merged 1 commit into from
Aug 6, 2019

Conversation

ericsaupe
Copy link
Contributor

The Cancel Inventory tab in admin had an inconsistent HTML
render than the rest of the file. This commit changes that
to be consistent with the other tabs rendered.

Description

The tabs are all rendered with HTML except for the Cancel Items tab. All tabs should be rendered the same way.

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)

The Cancel Inventory tab in admin had an inconsistent HTML
render than the rest of the file. This commit changes that
to be consistent with the other tabs rendered.
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks @ericsaupe!

Copy link
Contributor

@jacobherrington jacobherrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ericsaupe!

@jacobherrington jacobherrington merged commit 36b5337 into master Aug 6, 2019
@waiting-for-dev waiting-for-dev deleted the cancel-item-tab-consistency branch January 5, 2022 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants