Improve JS linting #3212
Improve JS linting #3212
Conversation
.eslintrc.json
Outdated
| "no-console": ["warn", { | ||
| "allow": ["warn"] | ||
| }], | ||
| "no-extra-semi": "warn", |
There was a problem hiding this comment.
Why a warning instead of an error for this rule? Do we expect to use extra semicolons during development?
There was a problem hiding this comment.
Given the discussion in #2847, I think the general consensus is to keep semicolons and only remove the ones that are completely unnecessary.
As for the warning instead of an error, I think that was an arbitrary decision 😅 I feel like the warnings should be used for stuff like this, whilst errors should be used when variable shadowing, unused vars or no var usage issues are present, but I'm completely willing to discuss what's the better choice for this. Let me know what you think! 🙌
There was a problem hiding this comment.
https://eslint.org/docs/rules/no-extra-semi
I think I'm reading the same way as @mdesantis. This is a non-blocker for me, but I would go ahead and make it an error personally.
There was a problem hiding this comment.
You're right, @mdesantis. Fixing it as we speak! 😉
This rule does not raise any offenses within Solidus codebase, making it safe to enable
We can specify ESLint environments to pre-define global JS variables not defined by Solidus; this way we can whitelist several vars found within the project's codebase without the need to specify them one by one See https://eslint.org/docs/user-guide/configuring#specifying-environments for details
ESLint will now check for all unused variables, regardless of their scope, but won't do so for function arguments
Solidus is not a JavaScript project, it does not makes much sense to enforce ES6+ syntax
aitbw
force-pushed
the
aitbw/better-js-linting
branch
from
c06e485
to
af8f6f6
Compare
|
Thanks @aitbw, you are great! |
Description
Following #3167, this PR aims to further improve JS linting by enabling non-offending rules, taking advantage of ESLint environments and whitelisting backend-specific global variables.
Checklist: