Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove conditional when searching an order when creating a shipment #3169

Merged
merged 1 commit into from
Apr 15, 2019
Merged

Remove conditional when searching an order when creating a shipment #3169

merged 1 commit into from
Apr 15, 2019

Conversation

aitbw
Copy link
Contributor

@aitbw aitbw commented Apr 10, 2019

Description

This conditional is not necessary anymore and can be safely removed.

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)

jacobherrington
jacobherrington approved these changes Apr 10, 2019
View reviewed changes
Copy link
Contributor

@jacobherrington jacobherrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 Awesome @aitbw!

@kennyadsl kennyadsl merged commit ec6d58c into solidusio:master Apr 15, 2019
@aitbw aitbw deleted the aitbw/remove-conditional branch April 15, 2019 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennyadsl kennyadsl kennyadsl approved these changes

@jacobherrington jacobherrington jacobherrington approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aitbw @kennyadsl @jacobherrington