When editing prices keep the currency locked.

[peterberkenbosch]

Description

When editing a price that has a different currency then the default currency set, the edit form defaults the currency to the default currency.

This PR fixes that by passing in the price currency to the currency form partial. It also improves the feature spec for editing prices by actually verifying that the edit worked.

before: https://cl.ly/420fb991710b
after: https://cl.ly/2b141684337f

Checklist:

• I have followed Pull Request guidelines
• I have added a detailed description into each commit message
• I have updated Guides and README accordingly to this change (if needed)
• I have added tests to cover this change (if needed)

[aitbw]

Thanks a lot, @peterberkenbosch! 🎉

[peterberkenbosch]

seems there are some unrelated failing specs on the rails51, I do see them in master now and then too actually. @kennyadsl could you restart the circleci workflow?

[kennyadsl]

@peterberkenbosch done!

[kennyadsl]

@peterberkenbosch Thanks, I think this works, I just have a doubt about if the currency choice should be disabled in the form. Can't/Shouldn't the price currency be edited by an admin user?

[peterberkenbosch]

I kept the existing expected(?) functionality in tact in this PR. Noticed the same though. Wanted to keep the PR to the bugfix, but I can update it to have the currency change as well. WDYT @kennyadsl

[kennyadsl]

I'm fine with the fix, just wondering. Maybe some git blame could help us remember why currency is not changeable.

[peterberkenbosch]

The currency component was introduced like that. It's used on multiple places actually.

[kennyadsl]

@peterberkenbosch can you please rebase now, I hope flaky specs are fixed with #3141 .

[peterberkenbosch]

@kennyadsl indeed! Specs are passing! Thanks

[jacobherrington]

I think this is a good fix for now. Thanks @peterberkenbosch!

I'd like to see the admin have the ability to change price currencies in the near future.

[peterberkenbosch]

Thanks @jacobherrington, will make another PR for that ;)

[kennyadsl]

Thanks @peterberkenbosch !!!