Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCUMENTATION] Update TaxLocation Namespace #3142

Merged
merged 1 commit into from
Mar 14, 2019
Merged

[DOCUMENTATION] Update TaxLocation Namespace #3142

merged 1 commit into from
Mar 14, 2019

Conversation

JuanCrg90
Copy link
Contributor

@JuanCrg90 JuanCrg90 commented Mar 13, 2019 •
edited
Loading

The TaxLocation namespace is wrong. This updates the documentation
to the correct reference.

https://github.com/solidusio/solidus/blob/f27114010a0725c57580ac0b03d701de8812597e/core/app/models/spree/tax/tax_location.rb

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)

@JuanCrg90
Update TaxLocation Namespace
dcf18e9 
The TaxLocation namespace is wrong. This updates the documentation
to the correct reference.
@JuanCrg90 JuanCrg90 changed the title Update TaxLocation Namespace [DOCUMENTATION] Update TaxLocation Namespace Mar 13, 2019
aitbw
aitbw approved these changes Mar 13, 2019
View reviewed changes
Copy link
Contributor

@aitbw aitbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JuanCrg90 ! 🎉

@jacobherrington
Copy link
Contributor

Thanks for making this change!

@kennyadsl
Copy link
Member

Thanks!

@jacobherrington jacobherrington merged commit 463e98e into solidusio:master Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennyadsl kennyadsl kennyadsl approved these changes

@aitbw aitbw aitbw approved these changes

@jacobherrington jacobherrington jacobherrington approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JuanCrg90 @jacobherrington @kennyadsl @aitbw