Add a stock locations filter configurable class #3116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aitbw
reviewed
Feb 21, 2019
guides/source/developers/shipments/stock-locations-filter.html.md
Outdated
Show resolved
Hide resolved
kennyadsl
force-pushed
the
kennyadsl/stock-locations-filter
branch
from
84829f4
to
beb537a
Compare
tvdeyen
approved these changes
Feb 25, 2019
guides/source/developers/shipments/stock-locations-filter.html.md
Outdated
Show resolved
Hide resolved
This class is helpful to filter stock locations that need to be taken into account by the SimpleCoordinator while generating shipments.
I think it's better to use the plural for locations and singular for sorter since we always use just one sorter class.
Reflecting the file name, stock locations sorter is preferred to stock location sorters. Also, there are some broken link to GitHub that have been fixed.
There's no need to keep that item in the menu since it's a technical implementation detail and could be confusing for someone who is not familiar with how the sorter works. We are linking stock locations sorter and filter into the Split Shipment page, which is the context where those class make sense to be mentioned.
This is how most of the users are doing so we should suggest this approach.
kennyadsl
force-pushed
the
kennyadsl/stock-locations-filter
branch
from
beb537a
to
59fb87c
Compare
jacobherrington
approved these changes
Mar 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This class is helpful to filter stock locations that need to be taken into account by the
SimpleCoordinatorwhile generating shipments.Checklist: