Update add-configuration guide page
#3001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aldesantis
requested changes
Dec 13, 2018
| Solidus does. | ||
|
|
||
| Another way to add configuration is by customizing `Rails.configuration`, see the the | ||
| [rails guides](https://guides.rubyonrails.org/configuring.html#custom-configuration) |
spaghetticode
force-pushed
the
update-guides-configuration
branch
from
4d9afb3
to
a4a7330
Compare
jacobherrington
suggested changes
Dec 13, 2018
| by inheriting from the class `Spree::Preferences::Configuration` just like | ||
| Solidus does. | ||
|
|
||
| Another way to add configuration is by customizing `Rails.configuration`, see the the |
There was a problem hiding this comment.
You've got the word the twice on this line.
| class][app-configuration-class] is where all of Solidus's preferences are | ||
| defined. | ||
| documentation][app-configuration-documentation]. The `Spree::AppConfiguration` | ||
| class is where all of Solidus's preferences are defined. |
There was a problem hiding this comment.
I prefer Solidus' over Solidus's, but I think both are technically okay.
Add some information on possible ways to add custom configuration to a Solidus store. Also, a reference to non existing page `app-configuration-class` was removed.
spaghetticode
force-pushed
the
update-guides-configuration
branch
from
a4a7330
to
3a35e30
Compare
jacobherrington
approved these changes
Dec 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #2986
Add some information on possible ways to add custom configuration to a Solidus
store.
Also, a reference to non existing page
app-configuration-classwas removed.