Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add margin to billing fields #2985

Merged
merged 3 commits into from
Jan 24, 2019

Conversation

jacobherrington
Copy link
Contributor

Really small, annoying style thing I noticed.

Before:
screen shot 2018-12-03 at 9 13 32 pm

After:
screen shot 2018-12-03 at 9 13 50 pm

@kennyadsl
Copy link
Member

Thanks @jacobherrington! Why the margin change to the button?

@jacobherrington
Copy link
Contributor Author

@kennyadsl I noticed it later and didn't want to make a separate PR.

The button is sitting at the very bottom of the page, it just adds a tiny amount of whitespace so that it's not against the bottom edge of the window.

kennyadsl
kennyadsl previously approved these changes Dec 5, 2018
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not address styling issues like this. More generic solutions are preferable. Otherwise the whole admin css getting more and more messier than it is already.

@jacobherrington
Copy link
Contributor Author

@tvdeyen I agree with your comments, this was sloppy CSS, but I do think we should have a presentable UI. As long as we have best practices CSS is fairly easy to overwrite.

@jacobherrington
Copy link
Contributor Author

@tvdeyen I updated the selector for adding margin to the billing field. The UI change is the same, but this is much more specific to this single element.

I looked for other places this CSS was needed and didn't find any, so I left the rules where they were. Please let me know if I need to do anything else for your approval.

@kennyadsl kennyadsl dismissed their stale review December 21, 2018 17:03

Other changes have been requested

@kennyadsl
Copy link
Member

@tvdeyen can you please review again?

@kennyadsl kennyadsl merged commit 6f05f9d into solidusio:master Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants