Move script files to bin + documentation #2971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice. |
Using bin/ for internal utils is the default for both Rails and Bundler. The script has now no extension and is marked as executable improving its usability (the user doesn't need to know how to deal with each extension) and maintainability (it's easy to switch to a ruby script just changing the shebang line). The doc is updated and env variables are passed with `env` making life easier for some non-bash shells such as fish-shell.
To help newcomers with the first run.
Many installation will only have a password-less root user available (e.g. Homebrew).
13e68d4
to
0b3409e
Compare
jacobherrington
approved these changes
Nov 24, 2018
|
@jacobherrington @elia the commits are great. There is no need to squash them. |
jacobherrington
approved these changes
Nov 24, 2018
There was a problem hiding this comment.
I'm alright with not squashing if you think they are okay @tvdeyen. I didn't realize that the last two were for PG and MySQL respectively.
|
Thanks @elia ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bin/for internal utils is the default for both Rails and Bundler.The script has now no extension and is marked as executable improving its
usability (the user doesn't need to know how to deal with each extension) and
maintainability (it's easy to switch to a ruby script just changing the
shebang line).
envmaking life easierfor some non-bash shells such as fish-shell.