Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Jbuilder to v2.8 to fix deprecation warnings #2962

Merged
merged 1 commit into from
Nov 22, 2018
Merged

Update Jbuilder to v2.8 to fix deprecation warnings #2962

merged 1 commit into from
Nov 22, 2018

Conversation

aitbw
Copy link
Contributor

@aitbw aitbw commented Nov 21, 2018

This PR fixes several deprecation warnings that showed up when running the Solidus' API test suite by updating Jbuilder up to its latest version (as per rails/jbuilder#447)

The message is the following:

DEPRECATION WARNING: Calling fragment_cache_key directly is deprecated and will be
removed in Rails 6.0. All fragment accessors now use the combined_fragment_cache_key
method that retains the key as an array, such that the caching stores can interrogate
the parts for cache versions used in recyclable cache keys.

kennyadsl
kennyadsl approved these changes Nov 21, 2018
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kennyadsl kennyadsl merged commit c10c6e9 into solidusio:master Nov 22, 2018
@aitbw aitbw deleted the nebulab/update-jbuilder branch November 22, 2018 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvdeyen tvdeyen tvdeyen approved these changes

@kennyadsl kennyadsl kennyadsl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aitbw @tvdeyen @kennyadsl