Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing i18n English values #2942

Merged
merged 1 commit into from
Nov 22, 2018
Merged

Add missing i18n English values #2942

merged 1 commit into from
Nov 22, 2018

Conversation

jacobherrington
Copy link
Contributor

No description provided.

tvdeyen
tvdeyen requested changes Nov 16, 2018
View reviewed changes
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message and PR title is misleading. Could you please rename it? And please squash the commits.

@jacobherrington jacobherrington changed the title Add missing yml values Add missing i18n English values Nov 16, 2018
@jacobherrington
Copy link
Contributor Author

@tvdeyen done!

@tvdeyen
Copy link
Member

tvdeyen commented Nov 17, 2018

Thanks

ericsaupe
ericsaupe approved these changes Nov 20, 2018
View reviewed changes
Copy link
Contributor

@ericsaupe ericsaupe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennyadsl kennyadsl merged commit 9f57373 into solidusio:master Nov 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvdeyen tvdeyen tvdeyen approved these changes

@ericsaupe ericsaupe ericsaupe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jacobherrington @tvdeyen @ericsaupe @kennyadsl