Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use filter over search for filter options #2940

Merged

Conversation

jacobherrington
Copy link
Contributor

Search seems like wrong word for this section

screenshot_2018-11-10 orders

@kennyadsl
Copy link
Member

Thanks! In the screenshot provided I can see Filter Result as button's text but from the code it looks like you used another i18n key (spree.filter). Is that just an issue with the screenshot provided?

Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is personal preference and should be done in the local install instead.

@jacobherrington
Copy link
Contributor Author

@kennyadsl I'm not sure I understand your question. I didn't change the button text, rather the section heading text from Search to Filter. Because this is not a conventional search, instead it's a set of filters to narrow results.

@tvdeyen I think Search really might be incorrect here because it's not a search. It's a series of filters. Your call though 👍

@kennyadsl
Copy link
Member

@jacobherrington sorry, I thought it was the button. 😄

Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the button of that section tells Filter Results I'm ok having the section's heading reflecting its action.

Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was under the same impression as Alberto.

@kennyadsl kennyadsl merged commit 25c118f into solidusio:master Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants