Add response with error message on failure destroy action #2920
Conversation
|
|
||
| def check_destroy_constraints | ||
| return unless name == 'undestroyable' | ||
| errors.add :base, 'You cant destroy undestroyable things!' |
There was a problem hiding this comment.
I'm not crazy about You cant destroy undestroyable things! I think there is a better way to phrase this.
We definitely need to add an apostrophe: You can't destroy undestroyable things!
Also, we probably want to add this to en.yml instead of just writing the string.
There was a problem hiding this comment.
This validation is only for testing as you can see. Adding it to en.yml is weird. But if you do not like the phrase itself, then you can offer absolutely any one to your taste.
There was a problem hiding this comment.
@bitberries That's fair, let's not worry about putting it in yaml then! I know it's picky, but I'd like to at least see the apostrophe :)
bitberry-dev
force-pushed
the
feature/backend_add_error_message_on_destroy_action
branch
from
518765f
to
7973a7a
Compare
|
@bitberryru failures should go away if you rebase against master, thanks! |
bitberry-dev
force-pushed
the
feature/backend_add_error_message_on_destroy_action
branch
from
7973a7a
to
3e4e7fb
Compare
Thank you, done. |
| context 'js format' do | ||
| subject { delete :destroy, params: params, format: 'js' } | ||
|
|
||
| it 'responses with error message' do |
There was a problem hiding this comment.
Can you change responses for responds? Thanks!
bitberry-dev
force-pushed
the
feature/backend_add_error_message_on_destroy_action
branch
from
3e4e7fb
to
582ab65
Compare
Hello again!
Now I noticed bug in admin when validations prevent destroy.
Your resource controller doesn't handle js format when destroy failures but your js code expects error message
Test and fix in commit! :)