Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customizing the reimbursement mailer class #2795

Merged

Conversation

jtapia
Copy link
Contributor

@jtapia jtapia commented Jul 6, 2018

Adds the ability to replace default reimbursement mailer class with a custom one, so there's no need to override default partials

Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a change in a code comment, thanks!

@@ -307,6 +307,14 @@ def default_pricing_options
# @api experimental
class_name_attribute :shipping_rate_tax_calculator_class, default: 'Spree::TaxCalculator::ShippingRate'

# Allows providing your own Mailer for order mailer.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this comment needs to be changed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, done

@jtapia jtapia force-pushed the chore/reimbursement_mailer_customization branch from f02f925 to 68eefa1 Compare July 7, 2018 16:00
Copy link
Member

@gmacdougall gmacdougall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@jtapia jtapia force-pushed the chore/reimbursement_mailer_customization branch from 443ea06 to 4d454fb Compare July 11, 2018 22:09
@kennyadsl kennyadsl merged commit 425240b into solidusio:master Jul 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants