Upgrade ruby to 2.3 #2794
Upgrade ruby to 2.3 #2794
Conversation
| brew install ruby sqlite3 imagemagick | ||
| gem install rails | ||
| ``` | ||
|
|
||
| See more detailed installation information below. | ||
|
|
||
| ### Upgrade Ruby on macOS | ||
| ### Upgrade Ruby on macOS | ||
|
|
||
| If you run macOS Sierra or an older OS, you system's version of Ruby will need | ||
| to be upgraded from 2.0.x to 2.2.2 or newer. You can check what version of Ruby |
There was a problem hiding this comment.
maybe we should also change this line?
There was a problem hiding this comment.
As long as Rails 5.1 allows >= 2.2.2 we should as well. There is no reason to not support 2.2 even if it’s EOL. It’s the stores decision to make, not ours. It’s the same with outdated gems. We still allow them. The same is true for Ruby versions. Stores can and should be able to decide which Ruby version to run.
|
I'm 👎 on this as well. Because if a store isn't able to reach 2.3, we could leave them out as Solidus goes forward. |
|
I agree with @tvdeyen we should support whatever the Rails versions are supporting. |
|
@ericsaupe Also, 2.3 minimum would go against Solidus principles, which is to make upgrades easier for users. If we remove a version of ruby, we need a practical reason for it. Mainly, I think, it's when that version of ruby stops working with the minimal version of Rails we're permitting. So, if Rails 5.2 supports 2.2, which I think it does, we should keep it. |
Issue: #2743
Ruby 2.2 has passed its end of life. This changed the required ruby versions to Ruby 2.3