Fix YARD warnings throughout core #2636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids issues with tooling (like YARD) trying to parse this as ruby, and getting confused when it encounters an erb tag. .rb.tt is the extension Rails uses for these types of files.
This avoids issues with tooling (like YARD) trying to parse this as ruby, and getting confused when it encounters an erb tag. .rb.tt is the extension Rails uses for these types of files.
This fixes all YARD warnings and errors in core (mostly due to slightly wrong syntax). It doesn't touch carton_mailer.rb, which has 3 warnings, but I intend to address them in a separate PR.
tvdeyen
approved these changes
Mar 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes all YARD warnings and errors in core (mostly due to slightly wrong syntax).
It doesn't touch
carton_mailer.rb, which has 3 warnings, but I intend to address them in a separate PR.