Namespace all testing_support/ files under Spree::TestingSupport namespace #2629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhawthorn
force-pushed
the
testing_support_namespace
branch
from
a9eba33
to
7973e7a
Compare
This is a fairly useless testing_support helper class (a fake ability). It's unlikely to be used by any stores. If it is it can easily be copied in. Doing this and adding @Private to get it out of our documentation.
I don't think we need to deprecate this because it is only used for tests and also is an empty method.
jhawthorn
force-pushed
the
testing_support_namespace
branch
from
7973e7a
to
0d09292
Compare
tvdeyen
approved these changes
Mar 15, 2018
kennyadsl
approved these changes
Mar 16, 2018
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously our test files defined a bunch of top level classes. This shouldn't really matter because it's just for tests, but it clutters up our documentation☹️ .
This PR makes some changes to avoid cluttering up the root namespace (at least as it appears to docs):
Spree::TestingSupport(with deprecations in place for the root constants)dummy_apprelated classes from yard (ApplicationController, etc.)BarAbility, and hides it from yardAfter:
