adding link to product in backend order summary #2609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhawthorn
reviewed
Mar 1, 2018
| @@ -4,7 +4,7 @@ | |||
| <%= render 'spree/admin/shared/image', image: item.variant.display_image, size: :mini %> | |||
| </td> | |||
| <td class="item-name"> | |||
| <%= item.variant.product.name %><br><%= "(" + variant_options(item.variant) + ")" unless item.variant.option_values.empty? %> | |||
| <%= link_to item.variant.product.name, edit_admin_product_path(item.variant.product), target: "_blank" %><br><%= "(" + variant_options(item.variant) + ")" unless item.variant.option_values.empty? %> | |||
There was a problem hiding this comment.
Looks great, but I'd rather not use target: "_blank" here. Links should open in the same tab.
There was a problem hiding this comment.
Ok, I think when someone works on an order he will want to keep it open while looking at a product details quickly but doesn't matter. I changed it.
jhawthorn
approved these changes
Mar 5, 2018
tvdeyen
approved these changes
Mar 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That won't be the PR of the month.... I am just adding an handy link back to the product when you are in the backend order summary.