Generate new stores with MySQL timestamp precision 6 #2598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
approved these changes
Feb 23, 2018
damianlegawiec
added a commit
to spark-solutions/spree
that referenced
this pull request
Nov 7, 2018
damianlegawiec
added a commit
to spark-solutions/spree
that referenced
this pull request
Nov 8, 2018
damianlegawiec
added a commit
to spark-solutions/spree
that referenced
this pull request
Nov 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under MySQL, we end up with caching issues due to timestamps by default only having 1 second precision. In recent versions of MySQL this can be increased to microsecond precision by specifying precision.
There's another PR open, #2479, which will
ALTER TABLEall existing tables to increase the precision. We haven't merged partly out of worry about how long the migration will take for existing users with large tables.This PR instead creates the table with the correct precision to begin with. This won't fix the issue for existing users, but it will for new users (and our spec suite). For existing MySQL users we can recommend they copy in and apply the migration from #2479 at their own time.