Distribute over eligible line items #2582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The calculator works as intended, but the test could be more strict.
Sinetheta
force-pushed
the
distribute-all
branch
from
d3dd747
to
7a1ab08
Compare
Since line_item level promotion adjustments are only applied to elligible line_items, there's a surprising interaction between the distributed amount calculator and the product promotion rule. The calculator distributes the preffered amount among all of the order's line_items but only discounts the order by the portion which was applied to the line_item with the elligible product.
By only giving weight to line_items which are elligible for the promotion, the entire preffered_amount will be distributed.
Sinetheta
force-pushed
the
distribute-all
branch
from
7a1ab08
to
5e2b124
Compare
tvdeyen
approved these changes
Feb 18, 2018
|
I don't believe this is the best way to fix this issue. Now that the handler is reliant on knowing about the promotion, there's little purpose for it being its own class. It is directly tied to the calculator and to only ever being used for promotions. A better approach would be passing the handler the list of items and an amount to distribute. Then updating the the interface to query for the amount that should be applied to a specific item. |
|
@adammathys I agree, but was hesitant to refuse the PR because of that. But on second thought we should think about a solution to only action on eligible items. |
Sinetheta
force-pushed
the
distribute-all
branch
from
634a55b
to
16e2d48
Compare
kennyadsl
reviewed
Feb 22, 2018
There was a problem hiding this comment.
Just left a small comment, the rest makes sense to me, thanks @Sinetheta !
Sinetheta
force-pushed
the
distribute-all
branch
from
16e2d48
to
ea26427
Compare
Sinetheta
force-pushed
the
distribute-all
branch
from
ea26427
to
7b837d5
Compare
jhawthorn
approved these changes
Feb 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a surprising interaction between the distributed amount calculator and the product promotion rule. The entire discount amount is distributed among all of an order's line_items, but only adjustments on line_items that match the promotion rule are considered "actionable" and contribute towards the order promo total.
https://github.com/solidusio/solidus/blob/master/core/app/models/spree/promotion/actions/create_item_adjustments.rb#L32
This means that as you add products to your cart, your discount can actually go down, which I don't imagine is a behaviour anyone would want.
Here the total discount has dropped from the preferred amount of $10 to ($22.99 / $38.98) = $5.90 the portion of the discount which was distributed to the item on sale.
I think there's larger discussion to be had about line item adjustments, but for now I'd just like to fix this one calculator. If only "actionable" line items can receive an adjustment then we need to distribute the desired amount among only those line items.