Refactor and convert Tabs component from CoffeeScript to JS #2549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stewart
approved these changes
Feb 1, 2018
graygilmore
approved these changes
Feb 2, 2018
kennyadsl
approved these changes
Feb 2, 2018
Previously we were using display: none to hide this element, which made it impossible to discover its outerWidth when it was hidden. This allows us to remove a hack which assumed it was 50px wide (which is never actually true) when we weren't able to discover its width.
Previously we had logic to see whether the container had grown or shrunk, and responded by either taking elements out of the dropdown or moving them in. Instead, this commit combines the separate code paths. Every time the width is changed all elements are removed from the DOM and one-by-one re-inserted into the correct parent. This shouldn't be significantly slower then the previous behaviour. We are looking at very few DOM nodes and are careful to not force layout at any point in the loop.
A minor nitpick, but we don't need jQuery here. In a number of places we were using the underlying objects (like $el[0]) so we might as well stick with those throughout.
jhawthorn
force-pushed
the
js_tabs_refactor
branch
from
7a56203
to
e7fe4fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we had logic to see whether the container had grown or shrunk, and responded by either taking elements out of the dropdown or moving them in.
Instead, this commit combines the separate code paths and every time the width is changed removes all elements from the DOM and one-by-one re-inserts them into the correct parent.
This shouldn't be significantly slower then the previous behaviour because we are looking at very few DOM nodes and are careful to not force layout at any point in the loop.
We also convert Tabs from CoffeeScript to plain JS, as well as use the DOM directly instead instead of jQuery.