Restore field for editing promotion per_code_usage_limit in admin #2497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ability to edit the per_code_usage_limit on existing promotions was lost amidst the updates in 374b931.
jordan-brough
force-pushed
the
show-per-code-usage-limit-in-admin
branch
from
3495703
to
12dbeca
Compare
jhawthorn
approved these changes
Jan 12, 2018
gmacdougall
approved these changes
Jan 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2422
The ability to edit the per_code_usage_limit on existing promotions was lost
during the updates in 374b931.
The fix here is a bit awkward because the placement of the field changes in the new-promotion page vs the edit-promotion page. The field is in a nice place on the new-promotion page (area where you specify that you are going to want multiple codes) but that area doesn't exist on the edit-promotion page.
I'm very open to other ideas on how to restore this. But in the worst case this PR at least restores the ability to see and edit the value.
Before:
After: