Update README.md summary about testing #2442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In solidusio#2433, I rewrote and expanded the getting started guide to discuss developing Solidus. In a review, tvdeyen requested some changes regarding testing. These changes are also required in Solidus's README: - Solidus no longer uses PhantomJS for running backend and frontend tests. Now it uses ChromeDriver. - tvdeyen also mentioned "We should not promote a custom ENV var [`FAIL_FAST=true`] but the rspec `--fail-fast` feature instead. But this is common rspec knowledge, I don't think we need to mention it in our guides at all." I also took the liberty of making the markdown more readable in this section.
jhawthorn
approved these changes
Dec 12, 2017
tvdeyen
approved these changes
Dec 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2433, I rewrote and expanding the getting started guide to discuss developing Solidus. In a review, @tvdeyen requested some changes regarding testing. These changes are also required in Solidus's README:
I also took the liberty of making the markdown more readable in this section.