Follow FactoryBot rename #2315
Merged
Follow FactoryBot rename #2315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FactoryGirl has been renamed to FactoryBot. This changes all occurences of FactoryGirl to follow their new naming convention. This also fixes our sample app builds.
houndci-bot
reviewed
Oct 23, 2017
| available_to_admin: true) } | ||
| let!(:second_method) { FactoryGirl.create(:payment_method, available_to_users: true, | ||
| let!(:second_method) { FactoryBot.create(:payment_method, available_to_users: true, |
There was a problem hiding this comment.
Block body expression is on the same line as the block start.
| @@ -596,9 +596,9 @@ def merge!(other_order, user = nil) | |||
| context "with more than one payment method" do | |||
| subject { order.available_payment_methods } | |||
|
|
|||
| let!(:first_method) { FactoryGirl.create(:payment_method, available_to_users: true, | |||
| let!(:first_method) { FactoryBot.create(:payment_method, available_to_users: true, | |||
There was a problem hiding this comment.
Block body expression is on the same line as the block start.
kennyadsl
approved these changes
Oct 23, 2017
schmijos
added a commit
to renuo/solidus_simple_sale_price
that referenced
this pull request
Apr 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FactoryGirl has been renamed to FactoryBot. This changes all occurences of
FactoryGirl to follow their new naming convention.
This also fixes our sample app builds.