Add headers to shipment method and tracking number #2169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the new table style we do not have a `border-bottom` anymore. So, it does not makes sense to style the border of table rows for `prism.js` `before-highlight` class.
Table row action color highlighting only worked for table cells. This expands the styles to table headers as well.
|
Please excuse the poor GIF quality on the second image. The background is actually not gray ;) |
Without headers it is hard to guess what "UPS same day" on a order shiments table actually means. Even more important, when in edit mode a form label is displayed in top of the form field what leads to jumpy and confusing UI. By adding headers to all view states this table row can have, we get a more consistent UI.
b79520d
to
e74f1b7
Compare
cbrunsdon
approved these changes
Aug 21, 2017
jhawthorn
approved these changes
Aug 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without headers it is hard to guess what "UPS same day" on a order shiments
table actually means.
Even more important, when in edit mode a form label is displayed in top of
the form field what leads to jumpy and confusing UI.
By adding headers to all view states this table row can have, we get a more
consistent UI.
Before
After