Rename assign_default_addresses! to assign_default_user_addresses! #1954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennyadsl
changed the title
kennyadsl
changed the title
mamhoff
approved these changes
May 23, 2017
|
@kennyadsl Would you mind rebasing on the current |
kennyadsl
force-pushed
the
rename-assign_default_addresses
branch
from
4037330
to
e6e5a22
Compare
|
@mamhoff done! |
tvdeyen
approved these changes
May 25, 2017
To make more clear that we are taking this default addresses from the user and not building a generic default addresses.
kennyadsl
force-pushed
the
rename-assign_default_addresses
branch
from
e6e5a22
to
2d08a41
Compare
|
rebased again due to another conflict with the CHANGELOG |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one is just for better documenting code via a method name. I think it makes more clear that we are taking addresses from the user and not building a generic (empty) address like it happens here.
This PR is related to #1811