Add validity period for Spree::TaxRate #1953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtylty
force-pushed
the
mtylty/time-aware-tax-rates
branch
from
c7f4cf2
to
c1b7147
Compare
|
This is also missing validations for dates but I can imaging we want this to have validations so that there can only be one valid tax rate at a time. |
mtylty
changed the title
|
I ended up duplicating code that's in |
mtylty
force-pushed
the
mtylty/time-aware-tax-rates
branch
from
a5bd420
to
162d5a2
Compare
mamhoff
approved these changes
May 31, 2017
| @@ -22,6 +22,7 @@ | |||
| <col style="width: 10%"> | |||
| <col style="width: 10%"> | |||
| <col style="width: 10%"> | |||
| <col style="width: 10%"> | |||
There was a problem hiding this comment.
We're now way over 100% with these width values.
There was a problem hiding this comment.
I'll see what I can do... I'm not that good with style and html 😅
This code adds a starts_at and expires_at datetime field to Spree::TaxRate so that tax rates can be scoped in time. Null values will be treated as valid so that a tax rate is valid by default and you can just ignore this feature if you don't need it. The Spree::Calculator::DefaultTax will always return 0 in case the tax rate is not valid (either not started or expired). Ref. solidusio#1857
mtylty
force-pushed
the
mtylty/time-aware-tax-rates
branch
from
162d5a2
to
10d5260
Compare
tvdeyen
approved these changes
Jun 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code adds a valid_from and valid_until datetime field to
Spree::TaxRateso that tax rates can be scoped in time.Null values will be treated as valid so that a tax rate is valid by default and you can just ignore this feature if you don't need it.
The
Spree::Calculator::DefaultTaxwill always return 0 in case the tax rate is not in its validity period.I was unsure how to implement it so I started with a scope but ended up thinking it's not really needed. @mamhoff if you could point me in the right direction I'd refactor it.
Ref. #1857