Allow flexible separator for promotion code #1951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericgross
force-pushed
the
promotion_seperator
branch
from
ee0d120
to
61f2da6
Compare
jordan-brough
suggested changes
May 23, 2017
| context "with a successful build" do | ||
| before do | ||
| allow(Spree::PromotionCodeBatchMailer) | ||
| .to receive(:promotion_code_batch_finished) | ||
| .and_call_original | ||
| .and_call_original |
There was a problem hiding this comment.
Accidental change here?
Rather than always seperating the promotion base_code from the suffix with an underscore (_), allow a seperator to be specified.
ericgross
force-pushed
the
promotion_seperator
branch
from
61f2da6
to
4fa319b
Compare
gmacdougall
approved these changes
May 23, 2017
jordan-brough
approved these changes
May 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than always seperating the promotion base_code from the suffix
with an underscore (_), allow a seperator to be specified.