Set belongs_to_required_by_default = false #1807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of Rails 5, belongs_to is now required by default. Our models,
including those in extensions and applications, aren't ready for this.
In Rails 5.0 there seems to be some bug that was preventing this new
default from affecting Spree::Base models.
> Spree::Base.belongs_to_required_by_default
=> nil
> config.active_record.belongs_to_required_by_default
=> true
In Rails 5.1 this seems to be fixed so we need to be explicit about what
we use. We might as well be explicit in Rails 5.0 anyways.
mamhoff
approved these changes
Mar 29, 2017
jordan-brough
approved these changes
Mar 29, 2017
cbrunsdon
approved these changes
Mar 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of Rails 5, belongs_to is now required by default. Our models, including those in extensions and applications, aren't ready for this.
In Rails 5.0 there seems to be some bug that was preventing this new default from affecting Spree::Base models.
In Rails 5.1 this seems to be fixed so we need to be explicit about what we use. We might as well be explicit in Rails 5.0 anyways.
cc @tvdeyen