Do not consider pending inventory units cancelable #1800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamhoff
force-pushed
the
fix-inventory-units-cancelable-scope
branch
from
b070c88
to
55331c7
Compare
|
Once #1787 is in, this will be green. I'll rebase then rather than create a merge conflict. |
Before an order is complete, all its inventory units are marked as "pending". Once the order passes the `complete` step, the inventory units' `pending` attribute is set to false. Item cancelations were designed for completed orders only, as before that, one could just change inventory on line items. Therefore, we should not consider pending inventory units as cancelable.
mamhoff
force-pushed
the
fix-inventory-units-cancelable-scope
branch
from
55331c7
to
beab2f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before an order is complete, all its inventory units are marked as "pending". Once
the order passes the
completestep, the inventory units'pendingattribute isset to false.
Item cancelations were designed for completed orders only, as before that, one could
just change inventory on line items. Therefore, we should not consider pending inventory
units as cancelable.