Fix loading transfer shipments #1781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Mar 17, 2017
| context "if the user is not authorized to update the shipment" do | ||
| let(:user) { create(:user, spree_api_key: 'abc123') } | ||
|
|
||
| custom_authorization! do |user| |
There was a problem hiding this comment.
Unused block argument - user. You can omit the argument if you don't care about it.
| let(:user) { create(:admin_user, spree_api_key: 'abc123') } | ||
| let(:stock_item) { create(:stock_item, backorderable: false) } | ||
| let(:variant) { stock_item.variant } | ||
| let(:order) { create(:completed_order_with_totals, user: user, line_items_attributes: [{variant: variant}]) } |
There was a problem hiding this comment.
Space inside { missing.
Space inside } missing.
mamhoff
force-pushed
the
fix-loading-transfer-shipments
branch
from
675b9ea
to
8220d5d
Compare
houndci-bot
reviewed
Mar 17, 2017
| context "if the user can not destroy shipments" do | ||
| let(:user) { create(:user, spree_api_key: 'abc123') } | ||
|
|
||
| custom_authorization! do |user| |
There was a problem hiding this comment.
Unused block argument - user. You can omit the argument if you don't care about it.
| context "if the user can not update shipments" do | ||
| let(:user) { create(:user, spree_api_key: 'abc123') } | ||
|
|
||
| custom_authorization! do |user| |
There was a problem hiding this comment.
Unused block argument - user. You can omit the argument if you don't care about it.
| let(:user) { create(:admin_user, spree_api_key: 'abc123') } | ||
| let(:stock_item) { create(:stock_item, backorderable: false) } | ||
| let(:variant) { stock_item.variant } | ||
| let(:order) { create(:completed_order_with_totals, user: user, line_items_attributes: [{variant: variant}]) } |
There was a problem hiding this comment.
Space inside { missing.
Space inside } missing.
Prior to this change, calling the transfer_to_{shipment, stock_location}
APIs with a non-existing source shipment number would result in a
`NoMethodError`. This change changes it to a 404, which I believe is more
appropriate.
Also, I'm introducing request specs for this endpoint here.
Fulfilling inventory units from another shipment changes the source shipment, and potentially destroys it. Just the `:read` ability for that is not enough.
When a shipment is split entirely (all its inventory units move to the new shipment), it is destroyed. This new ability check accounts for that case.
mamhoff
force-pushed
the
fix-loading-transfer-shipments
branch
from
8220d5d
to
592551b
Compare
tvdeyen
approved these changes
Mar 17, 2017
jhawthorn
approved these changes
Apr 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading shipments to transfer from, the previous code did not verify the shipment actually exists in the database. Also, the ability check was sketchy.
We currently have almost no API specs in this project. This adds one for those two endpoints.