Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing indexes for Spree::Taxon lft and rgt columns #1779

Merged
merged 1 commit into from
Oct 4, 2017

Conversation

vfonic
Copy link
Contributor

@vfonic vfonic commented Mar 17, 2017

  • These are used by awesome_nested_set to perform ordering and
    therefore indexes should be added to them

* These are used by `awesome_nested_set` to perform ordering and
  therefore indexes should be added to them
@vfonic
Copy link
Contributor Author

vfonic commented May 30, 2017

Bump!

Info straight from awesome_nested_set Readme:
https://github.com/collectiveidea/awesome_nested_set/blob/fbc84118a0ba495b934ea5cadbdcc56847ec2aa0/README.md#indexes

Perhaps we could add an index to depth column as well?

Copy link
Contributor

@jhawthorn jhawthorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Copy link
Contributor

@cbrunsdon cbrunsdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good by me too, thanks 👍

@jhawthorn jhawthorn merged commit a188422 into solidusio:master Oct 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants