Cleanup spree.js (and rewrite as plain JS) #1754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were declaring Spree to be a CoffeeScript class. This was harmless, because it was compiled into an empty function, but also unnecessary, because it had no class methods and was never used as a class.
This file's history was already replaced by the previous commit, so we might as well convert to plain JS at the same time. This is the only CoffeeScript (now only JS) file in the solidus_core gem, so it can now in theory be used in an app without needing to pull in CoffeeScript (assuming the app doesn't include solidus_frontend or soldius_backend).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were declaring the root
window.Spreeobject as a CoffeeScript class. This was harmless, because it was compiled into an empty function, but also unnecessary, because the object it created had no purpose. This replaces thewindow.Spreeobject with a normal object, which should be somewhat more inspectable when viewed in a devtools console.Before:
After:
This also rewrites the file as vanilla JS. Normally we avoid converting our files between coffee and JS, but this is the only JS file in the core project, so I think it is worth replacing. The entire file was already changed in the previous commit, so I believe this is a good time to make the change.