Improve JS i18n #1730
Merged
Improve JS i18n #1730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
approved these changes
Feb 22, 2017
| if (translation) { | ||
| return translation; | ||
| } else { | ||
| console.error("No translation found for " + key + "."); |
There was a problem hiding this comment.
I would consider to use a console.warn instead
Previously Martin Tomov updated the Handlebars "t" helper to behave more like the standard rails helper. Awesome! This commit extracts that behaviour so it is available to all javascripts via Spree.t
This allows us to conveniently use the activerecord attribute name translations, which is our preferred convention for storing translations, from JS.
This adds a scope option to our JS Spree.t similar to the one ruby's `I18n.t` accepts. This is especially useful from handlebars templates, which can't themselves concatenate the string keys.
Senjai
approved these changes
Feb 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few improvements to our (very basic) JS i18n
In c871eea @mtomov made the Handlebars
thelper understand the dot-separated paths. 👍This extracts that functionality to a
Spree.t, helper, so that JS doesn't need to dig through theSpree.translationsobject manually.This also adds a
scopeoption similar to the one ruby's18n.taccepts. This is especially useful from handlebars templates, which can't themselves concatenate the string keys.Finally, this adds
Spree.human_attribute_name, as well as ships the activerecord attribute translations to our JS.