Remove stock location configuration from admin "cart" page #1709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
tvdeyen
approved these changes
Feb 10, 2017
| @@ -130,7 +130,7 @@ | |||
| click_on 'Cart' | |||
| select2_search product.name, from: Spree.t(:name_or_sku) | |||
|
|
|||
| fill_in_quantity('table.stock-levels', 'quantity_0', 1) | |||
There was a problem hiding this comment.
I think we can also deprecate and remove the fill_in_quantity Capybara extension as well.
jhawthorn
deleted the
admin_cart_add_without_location_configured_packages
branch
This was referenced Feb 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the reasons discussed in #1696.
This removes the stock location in the simplest way possible. A follow up PR will have UI improvements to the page which this allows.
Before:
After:
