Don't treat "unreturned exchanges" differently in checkout #1690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the subject validations would never run, so line_item.errors would always be empty.
When finalizing shipments, only pending units are considered, so we should do the same here. When creating an "unreturned exchange", the order is created with an existing shipment which has already been shipped and finalized. This commit allows the AvailabilityValidator to consider that valid.
Now that AvailabilityValidator is smarter and understands pending inventory units, this isn't necessary. Inventory won't be checked for finalized inventory units.
gmacdougall
approved these changes
Jan 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the order's checkout state machine treated unreturned exchanges (orders created to charge for a previously cross-shipped exchange shipment) specially.
This PR removes that special treatment in favour of making the
AvailabilityValidatorsmarter and understanding inventory units which have already been shipped."Unreturned exchanges" may be extracted into their own gem in the future, this would more easily allow that.