Update product slug validation #1616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the existing length validation with a presence validation, because the length validation could lead to errors with short product names (see solidusio#1608 for more information).
tvdeyen
approved these changes
Nov 25, 2016
jhawthorn
added a commit
that referenced
this pull request
Dec 13, 2016
Update product slug validation
|
Thanks @fschwahn |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the existing length validation with a presence validation, because the length validation could lead to errors with short product names (see #1608 for more information).
Should I add a model spec for creating products with short names?
One more thing I noticed is the uniqueness validation, I think it's unnecessary because that's essentially what friendly_id handles. At least the
allow_blank: trueis unnecessary because we validate the length / presence, so this can never happen.