Move spree user methods to module #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also update LegacyUser to include User methods and move appropriate methods into the UserMethods module
Add deprication warning to initializer. If User class doesnt include UserMethods, add it and warn.
For api compatibility
Also add a comment to clarify the purpose of this initializer
|
👍 |
|
I like that approach. 👍 |
|
This is great. The address book functionality @richardnuno and I are working on is encapsulated into another module to include in UserMethods and won't be hard to merge into this when the time comes. |
jhawthorn
added a commit
that referenced
this pull request
Jul 8, 2015
Move spree user methods to module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move Spree::User logic into a mixin that can be included in the Spree.user_class that is defined.
I'm taking over #13. This has been rebased against master and I've implemented the feedback described there.