Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] Wallet & Support for non-credit card payment sources #1091

Closed
wants to merge 21 commits into from
Closed

[RFC] Wallet & Support for non-credit card payment sources #1091

wants to merge 21 commits into from

Commits on Apr 21, 2016

  1. Move common payment source specs into shared example file 

    Extracted from these commits from mamhoff:

- spree/spree@7f706d0
- spree/spree@a3b66ae
    @jordan-brough
    jordan-brough committed Apr 21, 2016
    Configuration menu
    Copy the full SHA
    2b89ef8 View commit details
    Browse the repository at this point in the history

  2. Move common code from CreditCard into PaymentSource 

    Based largely on this commit from mamhoff:

- spree/spree@a3b66ae
    @jordan-brough
    jordan-brough committed Apr 21, 2016
    Configuration menu
    Copy the full SHA
    0b64019 View commit details
    Browse the repository at this point in the history

  3. Introduce Wallet and WalletSource classes

    @jordan-brough
    jordan-brough committed Apr 21, 2016
    Configuration menu
    Copy the full SHA
    0e69b2e View commit details
    Browse the repository at this point in the history

  4. Add PaymentSource#reusable? concept 

    To help tell whether payment sources should be saved in the Wallet or
just reused in general (e.g. for unreturned exchange charges).
    @jordan-brough
    jordan-brough committed Apr 21, 2016
    Configuration menu
    Copy the full SHA
    120c88e View commit details
    Browse the repository at this point in the history

  5. StoreCredit temporary workaround

    @jordan-brough
    jordan-brough committed Apr 21, 2016
    Configuration menu
    Copy the full SHA
    1006405 View commit details
    Browse the repository at this point in the history

  6. Update persist_user_credit_card for the Wallet

    @jordan-brough
    jordan-brough committed Apr 21, 2016
    Configuration menu
    Copy the full SHA
    bc0d432 View commit details
    Browse the repository at this point in the history

  7. Update assign_default_credit_card for the Wallet

    @jordan-brough
    jordan-brough committed Apr 21, 2016
    Configuration menu
    Copy the full SHA
    7d8e967 View commit details
    Browse the repository at this point in the history

  8. Rename temporary_credit_card -> temporary_payment_source

    @jordan-brough
    jordan-brough committed Apr 21, 2016
    Configuration menu
    Copy the full SHA
    97141cc View commit details
    Browse the repository at this point in the history

  9. Allow passing wallet_source_id instead of existing_card_id 

    TODO: Use this in frontend and deprecate `existing_card_id`.
    @jordan-brough
    jordan-brough committed Apr 21, 2016
    Configuration menu
    Copy the full SHA
    1b7ffcf View commit details
    Browse the repository at this point in the history

  10. Use wallet_source_id instead of existing_card in frontend 

    TODO: Deprecate existing_card and existing_card_id
    @jordan-brough
    jordan-brough committed Apr 21, 2016
    Configuration menu
    Copy the full SHA
    e79571b View commit details
    Browse the repository at this point in the history

  11. Deprecate existing_card and existing_card_id parameters

    @jordan-brough
    jordan-brough committed Apr 21, 2016
    Configuration menu
    Copy the full SHA
    22d528b View commit details
    Browse the repository at this point in the history

  12. Allow payment sources that don't have belongs_to :user

    @jordan-brough
    jordan-brough committed Apr 21, 2016
    Configuration menu
    Copy the full SHA
    656eb03 View commit details
    Browse the repository at this point in the history

  13. Migrate CreditCard#default to Wallet, migrate data, drop column 

    And deprecate User#default_credit_card
    @jordan-brough
    jordan-brough committed Apr 21, 2016
    Configuration menu
    Copy the full SHA
    9d203b4 View commit details
    Browse the repository at this point in the history

  14. Deprecate User#payment_sources

    @jordan-brough
    jordan-brough committed Apr 21, 2016
    Configuration menu
    Copy the full SHA
    0ec099f View commit details
    Browse the repository at this point in the history

Commits on May 25, 2016

  1. Update add_after_order_complete for non-PaymentSource sources 

    For any stores using legacy payment sources that do not inherit from
PaymentSource.
    @jordan-brough
    jordan-brough committed May 25, 2016
    Configuration menu
    Copy the full SHA
    ede74b6 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2016

  1. make Spree::StoreCredit inherit from Spree::PaymentSource

    @peterberkenbosch
    peterberkenbosch committed Jun 1, 2016
    Configuration menu
    Copy the full SHA
    1d21e16 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2016

  1. Merge pull request #2 from peterberkenbosch/non-credit-card-payment-s… 

    …ources

make Spree::StoreCredit inherit from Spree::PaymentSource
    @jordan-brough
    jordan-brough committed Jun 6, 2016
    Configuration menu
    Copy the full SHA
    b100e4b View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2016

  1. Fix comment text

    @jordan-brough
    jordan-brough committed Jun 22, 2016
    Configuration menu
    Copy the full SHA
    dad6ab7 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2016

  1. renamed the wallet_source to wallet_payment_source 

    renamed wallet_source#source to payment_source
reflected the name change in the migrations as well.

forgot to add the renamed files
    @peterberkenbosch
    peterberkenbosch committed Jul 26, 2016
    Configuration menu
    Copy the full SHA
    2f6d1c4 View commit details
    Browse the repository at this point in the history

  2. add validation for payment_source on the wallet_payment_source. 

    Makes sure the `payment_source` is a `Spree::PaymentSource`

add spec for wallet_payment_source#payment_source validation
fixed typo on the error key message

add locale for invalid payment_source
    @peterberkenbosch
    peterberkenbosch committed Jul 26, 2016
    Configuration menu
    Copy the full SHA
    42b2d61 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2016

  1. please the hound gods

    @peterberkenbosch @jordan-brough
    peterberkenbosch authored and jordan-brough committed Jul 27, 2016
    Configuration menu
    Copy the full SHA
    4cdc669 View commit details
    Browse the repository at this point in the history