Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sqlite3 dependency version conflicts with activerecord sqlite adapter #3087

Closed
mdesantis opened this issue Feb 7, 2019 · 1 comment
Closed

sqlite3 dependency version conflicts with activerecord sqlite adapter #3087

mdesantis opened this issue Feb 7, 2019 · 1 comment
Labels
type:bug Error, flaw or fault

Comments

@mdesantis
Copy link
Contributor

mdesantis commented Feb 7, 2019 •
edited
Loading

On February 04, 2019 sqlite3 1.4.0 has been released. This version breaks ActiveRecord 5.2.2 SQLite adapter, which requires sqlite3 ~> 1.3.6: https://github.com/rails/rails/blob/v5.2.2/activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb#L12

Solidus Version: 2.9.0.alpha@a736ec34e

To Reproduce

  1. Checkout Solidus repo
  2. Run bundle exec rake sandbox

Current behavior

It fails showing the following error:

rake aborted!
LoadError: Error loading the 'sqlite3' Active Record adapter. Missing a gem it depends on? can't activate sqlite3 (~> 1.3.6), already activated sqlite3-1.4.0. Make sure all dependencies are added to Gemfile.
/home/maurizio/Sviluppo/Nebulab/solidus/sandbox/config/environment.rb:5:in `<main>'
/home/maurizio/.asdf/installs/ruby/2.6.0/bin/bundle:23:in `load'
/home/maurizio/.asdf/installs/ruby/2.6.0/bin/bundle:23:in `<main>'

Caused by:
Gem::LoadError: can't activate sqlite3 (~> 1.3.6), already activated sqlite3-1.4.0. Make sure all dependencies are added to Gemfile.
/home/maurizio/Sviluppo/Nebulab/solidus/sandbox/config/environment.rb:5:in `<main>'
/home/maurizio/.asdf/installs/ruby/2.6.0/bin/bundle:23:in `load'
/home/maurizio/.asdf/installs/ruby/2.6.0/bin/bundle:23:in `<main>'
Tasks: TOP => db:drop => db:load_config => environment
(See full trace by running task with --trace)

Expected behavior

It should successfully create the sandbox
@mdesantis
Copy link
Contributor Author

mdesantis commented Feb 7, 2019 •
edited
Loading

Fixing PR: #3088

mdesantis added a commit to mdesantis/solidus that referenced this issue Feb 7, 2019
@mdesantis
Lock sqlite3 version to 1.3
4979232 
Related to solidusio#3087. ActiveRecord 5.2.2 has sqlite3 dependency locked to ~>
1.3.6, we need to reflect that in order to avoid conflicts due to
sqlite3 1.4 version releasement.
@mdesantis mdesantis mentioned this issue Feb 7, 2019
Merged
5 tasks
aitbw added a commit to aitbw/solidus_legacy_return_authorizations that referenced this issue Feb 7, 2019
@aitbw
Lock SQLite3 version to 1.3
e3829ee 
See solidusio/solidus#3087 for details.
@jacobherrington jacobherrington added the type:bug Error, flaw or fault label Feb 8, 2019
mdesantis added a commit to mdesantis/solidus that referenced this issue Feb 8, 2019
@mdesantis
Fix sqlite3 version conflict on sandbox generation
6fe4886 
Fixes solidusio#3087. `rails new` generates a Gemfile with `gem 'sqlite3'`
dependency declaration, but since sqlite3 1.4 has been released it
conflicts with activerecord sqlite3 adapter dependency declaration,
which is `sqlite3 ~> 1.3.6`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:bug Error, flaw or fault
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mdesantis @jacobherrington