Merge pull request #1048 from CasperSleep/multi_promocode_perf_improv…

…ement Fix performance issue on coupon code application for large sets
solidusio · Apr 7, 2016 · d92dc8a · d92dc8a
2 parents 1a200b3 + 4740dcf
commit d92dc8a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/backend/app/views/spree/admin/promotion_codes/index.csv.ruby b/backend/app/views/spree/admin/promotion_codes/index.csv.ruby
@@ -1,6 +1,6 @@
 CSV.generate do |csv|
  csv << ['Code']
- @promotion.codes.order(:id).each do |code|
- csv << [code.value]
+ @promotion.codes.order(:id).pluck(:value).each do |value|
+ csv << [value]
  end
 end
diff --git a/core/app/models/spree/promotion_handler/coupon.rb b/core/app/models/spree/promotion_handler/coupon.rb
@@ -86,7 +86,7 @@ def promotion_exists_on_order?(order, promotion)
 
  def determine_promotion_application_result
  detector = lambda { |p|
- p.source.promotion.codes.any? { |code| code.value == order.coupon_code.downcase }
+ p.source.promotion.codes.where(value: order.coupon_code.downcase).any?
  }
 
  # Check for applied adjustments.