Skip to content

Commit

Permalink
Remove support for ruby v2.5
Browse files Browse the repository at this point in the history
Ruby v2.5 is EOL since 05 Apr 2021 [1].

Our new release policy [2] makes it clear that we don't support Ruby
versions that are no longer maintained.

[1] - https://www.ruby-lang.org/en/downloads/branches/
[2] - https://solidus.io/release_policy/
  • Loading branch information
waiting-for-dev committed Jan 10, 2023
1 parent 16d1e37 commit bfd56a4
Show file tree
Hide file tree
Showing 7 changed files with 8 additions and 18 deletions.
14 changes: 2 additions & 12 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -277,17 +277,7 @@ jobs:
BUILDKITE_ANALYTICS_EXECUTION_NAME_PREFIX: "(<< parameters.ruby >>:<< parameters.rails >>:<< parameters.database >>:<< parameters.paperclip >>)"
steps:
- setup
- when:
condition:
not:
equal: [<<parameters.ruby>>, '2.5']
steps:
- libvips
- when:
condition:
equal: [<<parameters.ruby>>, '2.5']
steps:
- imagemagick
- libvips
- test
- notify

Expand Down Expand Up @@ -356,6 +346,6 @@ workflows:
- test_solidus:
context: slack-secrets
name: *name
matrix: { parameters: { rails: ['5.2'], ruby: ['2.5'], database: ['sqlite'], paperclip: [true] } }
matrix: { parameters: { rails: ['5.2'], ruby: ['2.6'], database: ['sqlite'], paperclip: [true] } }
- dev_tools:
context: slack-secrets
2 changes: 1 addition & 1 deletion api/solidus_api.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ Gem::Specification.new do |s|
f.match(%r{^(spec|script)/})
end

s.required_ruby_version = '>= 2.5.0'
s.required_ruby_version = '>= 2.6.0'
s.required_rubygems_version = '>= 1.8.23'

s.add_dependency 'jbuilder', '~> 2.8'
Expand Down
2 changes: 1 addition & 1 deletion backend/solidus_backend.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ Gem::Specification.new do |s|
f.match(%r{^(spec|script)/})
end

s.required_ruby_version = '>= 2.5.0'
s.required_ruby_version = '>= 2.6.0'
s.required_rubygems_version = '>= 1.8.23'

s.add_dependency 'solidus_api', s.version
Expand Down
2 changes: 1 addition & 1 deletion core/lib/spree/core.rb
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ class GatewayError < RuntimeError; end

if Gem::Version.new(RUBY_VERSION) < Gem::Version.new("2.7")
Spree::Deprecation.warn <<~HEREDOC
Ruby 2.5 & Ruby 2.6 (both EOL) are deprecated and will not be supported anymore from the next Solidus version.
Ruby 2.6, which reached EOL, is deprecated and will not be supported anymore from the next Solidus version.
Please, upgrade to a more recent Ruby version.
Read more on the release notes for different Ruby versions here:
https://www.ruby-lang.org/en/downloads/releases/
Expand Down
2 changes: 1 addition & 1 deletion core/solidus_core.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ Gem::Specification.new do |s|
f.match(%r{^(spec|script)/})
end

s.required_ruby_version = '>= 2.5.0'
s.required_ruby_version = '>= 2.6.0'
s.required_rubygems_version = '>= 1.8.23'

%w[
Expand Down
2 changes: 1 addition & 1 deletion sample/solidus_sample.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ Gem::Specification.new do |s|
f.match(%r{^(spec|script)/})
end

s.required_ruby_version = '>= 2.5.0'
s.required_ruby_version = '>= 2.6.0'
s.required_rubygems_version = '>= 1.8.23'

s.add_dependency 'solidus_core', s.version
Expand Down
2 changes: 1 addition & 1 deletion solidus.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ Gem::Specification.new do |s|

s.files = Dir['README.md', 'lib/**/*']

s.required_ruby_version = '>= 2.5.0'
s.required_ruby_version = '>= 2.6.0'
s.required_rubygems_version = '>= 1.8.23'

s.add_dependency 'solidus_api', s.version
Expand Down

0 comments on commit bfd56a4

Please sign in to comment.